Compute transaction input for executing transactions #28
Conversation
crates/format/src/input.rs
Outdated
| Literal(String), | ||
| AddressRef(String), // will be "Contract.address" |
There was a problem hiding this comment.
Should be a doc-comment
| Literal(String), | |
| AddressRef(String), // will be "Contract.address" | |
| Literal(String), | |
| /// For example: `Contract.address` | |
| AddressRef(String), |
There was a problem hiding this comment.
Can you please apply the suggestion or fix it?
There was a problem hiding this comment.
Fixed in the new revision
xermicus
left a comment
xermicus
left a comment
There was a problem hiding this comment.
The CI keeps failing, can you please make it green before we merge.
crates/core/src/driver/mod.rs
Outdated
| } | ||
| } | ||
| Err(err) => { | ||
| log::debug!( |
There was a problem hiding this comment.
So this should bail out too shouldn't it?
There was a problem hiding this comment.
Yes, I was planning to look over all the bad condition and bail out them.
crates/core/src/driver/mod.rs
Outdated
| } | ||
| } | ||
| } else { | ||
| log::debug!( |
There was a problem hiding this comment.
Addressed in the new revision
crates/core/src/driver/mod.rs
Outdated
| .insert(contract_name.clone(), parsed_abi); | ||
| } | ||
| Err(err) => { | ||
| log::debug!( |
There was a problem hiding this comment.
Also here. Although it should never happen that this doesn't parse. Please error out early.
There was a problem hiding this comment.
Addressed in the new revision
crates/format/src/input.rs
Outdated
| Literal(String), | ||
| AddressRef(String), // will be "Contract.address" |
There was a problem hiding this comment.
Can you please apply the suggestion or fix it?
Compute transaction input for executing transactions. For this, we extracted the ABI property from the metadata property (after compilation process) and we created the parameters and the metadata that needs to be send to the deployed contract in order to execute it.